The `--end-date` for `daymet` dataset is not functioning properly

[kasra-keshavarz]

The --end-date does not subset up to the day, but rather, looks at the yearly file. This needs to be addressed.

[wknoben]

Could this explain why I'm missing a lot of files that should contain anywhere between 1 and 3 days of the 2023 data?

[kasra-keshavarz]

That is probably a cause, I will have a look. What days are you missing and what did you call with the scripts?

[kasra-keshavarz]

Could this explain why I'm missing a lot of files that should contain anywhere between 1 and 3 days of the 2023 data?

Is the problem still persisting? Can you give me a bit more detail?

[kasra-keshavarz]

@wknoben a ping on this.

[wknoben]

Sorry, I don't have the details anymore, but based on my notes this had something to do with asking for dates that are outside the time period covered by the data set, and dates that are not exactly at the start/end of a year. Snippet from my workaround code (https://github.com/CH-Earth/camels_spat/blob/864f47b63981adb55eff40e5036b74484fe7c503/7_forcing_data/6d_daymet_to_basins.py#L122-L132):

# Limit the dates to the Daymet period
# According to Kasra, datatool should be able to handle periods that are outside what the data has
# BUT this does not apply to Daymet (datatool: 2024-06-01)
if start_date.year < 1980:
    start_date = datetime(1980,1,1)
if final_date.year > 2023:
    final_date = datetime(2023,12,31)


# Fix a further issue where datatool doesn't like dates that are not on the start/end of the year
start_date = start_date.replace(day=1, month=1)
final_date = final_date.replace(day=31, month=12)