From 4953289acc332acd6ca3496970772fb0ed69a52f Mon Sep 17 00:00:00 2001
From: Byron Williams <byronawilliams@gmail.com>
Date: Sat, 5 Sep 2026 10:13:54 -0700
Subject: [PATCH] fix(ci): remove duplicate python-ci call from
 pr-validation.yml

The core-validation job in pr-validation.yml re-invoked the shared
python-ci.yml reusable at the same pinned SHA already called by
ci.yml's ci job, roughly doubling PR CI cost (quality checks, unit
tests, integration tests, security tests, coverage combine, LLM
governance, and the Python matrix all ran twice per PR).

Remove the core-validation job and its reusable call. Keep ci.yml's
call as the single source of truth. Update validation-summary to drop
the needs.core-validation reference, the CORE_RESULT env var, its
result-based echo block, and the failure condition that tested it;
leaving that reference in place after deleting the job would have
caused the workflow to fail to parse.

The dependency-standards-validation job, a normal job with its own
steps that produces the required Dependency & Standards Validation
status check, is untouched.

#CRITICAL validation-summary is not itself a required status check in
this repo (it is named Validation Summary); the four required contexts
were verified against the org ruleset
(gh api repos/ByronWilliamsCPA/rag-processor/rules/branches/main)
before this change: CI Gate from ci.yml's ci-gate job, Security Gate
Validation from security-analysis.yml, Check REUSE Compliance from
reuse.yml, and Dependency & Standards Validation from the
dependency-standards-validation job kept in this file.
#VERIFY re-run the ruleset query after merge to confirm all four
required contexts still report on the next PR.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .github/workflows/pr-validation.yml | 26 ++------------------------
 1 file changed, 2 insertions(+), 24 deletions(-)

diff --git a/.github/workflows/pr-validation.yml b/.github/workflows/pr-validation.yml
index 01bd8e0..54ca707 100644
--- a/.github/workflows/pr-validation.yml
+++ b/.github/workflows/pr-validation.yml
@@ -25,21 +25,6 @@ permissions:
 
 jobs:
   # ==========================================================================
-  # Org-Level PR Validation (Core Checks)
-  # ==========================================================================
-  core-validation:
-    name: Core Validation
-    permissions:
-      contents: read
-      pull-requests: write
-      checks: write
-    uses: ByronWilliamsCPA/.github/.github/workflows/python-ci.yml@7d12f5486ab5c856397ebaa4acd3c99ca385227c # main
-    with:
-      python-version: '3.12'
-      coverage-threshold: 80
-      enable-dead-code-check: true
-      no-build: false
-  # ==========================================================================
   # Additional Checks (Template-Specific)
   # ==========================================================================
 
@@ -192,7 +177,7 @@ jobs:
     name: Validation Summary
     runs-on: ubuntu-latest
     timeout-minutes: 10
-    needs: [core-validation, dead-code, link-check, dependency-standards-validation]
+    needs: [dead-code, link-check, dependency-standards-validation]
     if: always()
     steps:
       - name: Harden runner
@@ -202,7 +187,6 @@ jobs:
 
       - name: Check validation results
         env:
-          CORE_RESULT: ${{ needs.core-validation.result }}
           DEP_RESULT: ${{ needs.dependency-standards-validation.result }}
           DEAD_CODE_RESULT: ${{ needs.dead-code.result }}
           LINK_RESULT: ${{ needs.link-check.result }}
@@ -210,12 +194,6 @@ jobs:
           echo "## PR Validation Summary" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
 
-          if [ "$CORE_RESULT" == "success" ]; then
-            echo "Core Validation: Passed" >> $GITHUB_STEP_SUMMARY
-          else
-            echo "Core Validation: $CORE_RESULT" >> $GITHUB_STEP_SUMMARY
-          fi
-
           if [ "$DEP_RESULT" == "success" ]; then
             echo "Dependency and Standards Validation: Passed" >> $GITHUB_STEP_SUMMARY
           else
@@ -234,7 +212,7 @@ jobs:
             echo "Link Check: $LINK_RESULT" >> $GITHUB_STEP_SUMMARY
           fi
           # Fail if required checks failed
-          if [ "$CORE_RESULT" == "failure" ] || [ "$DEP_RESULT" == "failure" ]; then
+          if [ "$DEP_RESULT" == "failure" ]; then
             echo ""
             echo "Required validation checks failed. Please review and fix issues." >> $GITHUB_STEP_SUMMARY
             exit 1