Skip to content

fix: unskip test_get_batch_status_from_redis in test_websocket_router #44

Description

@williaby

Problem

One test in tests/unit/test_websocket_router.py is permanently skipped because get_batch_status is imported at module level from queue.jobs, which triggers a real Redis connection attempt before fakeredis patches can be applied.

Fix Options

  1. Defer the import inside the function under test (preferred)
  2. Use importlib.reload() after patching in the test setup

Acceptance Criteria

  • uv run pytest tests/ -q shows 0 skipped
  • No real Redis connection required in unit tests

Context

Discovered during Phase 1 completion audit. The overall test suite passes (334+ tests) but this one test has been skipped since the websocket router was implemented.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions