From fbf4a23aad79d7503c430f6fba24897def1863c5 Mon Sep 17 00:00:00 2001
From: Byron Williams <byronawilliams@gmail.com>
Date: Sat, 5 Sep 2026 10:13:43 -0700
Subject: [PATCH] fix(ci): remove duplicate python-ci call from
 pr-validation.yml

The core-validation job in pr-validation.yml re-invoked the shared
python-ci.yml reusable at the same pinned SHA already called by
ci.yml's ci job, roughly doubling PR CI cost (quality checks, unit
tests, integration tests, security tests, coverage combine, LLM
governance, and the Python matrix all ran twice per PR).

Remove the core-validation job and its reusable call. Keep ci.yml's
call as the single source of truth. Update validation-summary (which
produces the required Dependency & Standards Validation status check)
to drop the needs.core-validation reference, its result-based echo
block, and the failure condition that tested it; leaving that
reference in place after deleting the job would have caused the
workflow to fail to parse.

#CRITICAL validation-summary's required-context role was verified
against the org ruleset (gh api repos/ByronWilliamsCPA/audio-processor/rules/branches/main)
before this change: CI Gate is produced by ci.yml's gate job, Security
Gate Validation by security-analysis.yml, and Check REUSE Compliance by
reuse.yml, none of which reference core-validation.
#VERIFY re-run the ruleset query after merge to confirm all four
required contexts still report on the next PR.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .github/workflows/pr-validation.yml | 30 +----------------------------
 1 file changed, 1 insertion(+), 29 deletions(-)

diff --git a/.github/workflows/pr-validation.yml b/.github/workflows/pr-validation.yml
index 8883cc6..6280f2f 100644
--- a/.github/workflows/pr-validation.yml
+++ b/.github/workflows/pr-validation.yml
@@ -26,21 +26,6 @@ permissions:
 
 jobs:
   # ==========================================================================
-  # Org-Level PR Validation (Core Checks)
-  # ==========================================================================
-  core-validation:
-    name: Core Validation
-    permissions:
-      contents: read
-      pull-requests: write
-      checks: write
-    uses: ByronWilliamsCPA/.github/.github/workflows/python-ci.yml@7d12f5486ab5c856397ebaa4acd3c99ca385227c  # main
-    with:
-      python-version: '3.12'
-      coverage-threshold: 80
-      enable-dead-code-check: true
-      no-build: false  # project uses hatchling build backend; uv must build the editable install
-  # ==========================================================================
   # Additional Checks (Template-Specific)
   # ==========================================================================
 
@@ -126,7 +111,7 @@ jobs:
     name: Dependency & Standards Validation
     runs-on: ubuntu-latest
     timeout-minutes: 15
-    needs: [core-validation, dead-code, link-check]
+    needs: [dead-code, link-check]
     if: always()
     steps:
       - name: Harden runner
@@ -141,12 +126,6 @@ jobs:
           echo "## PR Validation Summary" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
 
-          if [ "${{ needs.core-validation.result }}" == "success" ]; then
-            echo "✅ Core Validation: Passed" >> $GITHUB_STEP_SUMMARY
-          else
-            echo "❌ Core Validation: ${{ needs.core-validation.result }}" >> $GITHUB_STEP_SUMMARY
-          fi
-
           if [ "${{ needs.dead-code.result }}" == "success" ]; then
             echo "✅ Dead Code Check: Passed" >> $GITHUB_STEP_SUMMARY
           else
@@ -158,12 +137,5 @@ jobs:
           else
             echo "⚠️ Link Check: ${{ needs.link-check.result }}" >> $GITHUB_STEP_SUMMARY
           fi
-          # Fail if core validation failed
-          if [ "${{ needs.core-validation.result }}" == "failure" ]; then
-            echo ""
-            echo "❌ Core validation checks failed. Please review and fix issues." >> $GITHUB_STEP_SUMMARY
-            exit 1
-          fi
-
           echo ""
           echo "✅ All validation checks passed!" >> $GITHUB_STEP_SUMMARY