visual horros with Lodestone and Rubidium

[CipherUnknown]

When combining the mod with Rubidium and Lodestone (Malum's library mod) blocks flick between light and black colors, seemingly at random.

Minecraft version: 1.18.2
Forge version: 40.2.1
Rubidium Version: 0.5.5
Lodestone: 1.3
Phosphophyllite: 0.6.0-beta1.6
Quartz Version: 0.0.0-beta.1.4
with only these mods

^ This rapidly flicks between normal and completely black

Log: https://pastebin.com/WjWXWNVS
(Same error for 28,000 lines)

[RogueLogix]

Try building a bigger reactors turbine with glass. If that fixes the visual issues while its in view, this is likely the same issue that was just patched in 1.19.

[CipherUnknown]

Did some testing around, building a turbine at first had no effect, and after a couple of seconds it seemed fixed. Found out that if was fixed as long as you hold any item in you hand. Holding nothing broke everything as usual.

Keeping the turbine built, kept the creative inventory open for maybe 2 minutes and after closing everything seemed, once again stable. Shortly after, everything back to black. Randomly breaking and fixing itself with the turbine built.

Again, only using the mentioned mods.

[embeddedt]

I looked into this briefly since I'm working on a more reliable Rubidium fork, but I don't think it's caused by Rubidium.

Please keep in mind I'm quite inexperienced with modern OpenGL, but I suspect either Lodestone or Quartz are tearing down their render state too aggressively and unbinding some buffer type that Sodium uses, but vanilla does not. This would explain why the issue isn't seen with the vanilla renderer.

In particular, the code here looks rather suspicious (it would be cleaner to save the old state and restore it, but I don't know how that affects performance). This issue can't be reproduced with Rubidium and only one of the mods at a time though, so it must be some type of interaction between their rendering hooks.

The issue on Lodestone's end has a pointer to what part of their rendering code is relevant, if anyone else happens across this and wants to dig in further.

[embeddedt]

I found a kludge to prevent the flickering, but I think the 1.18 version of Quartz has a flawed design: it calls many OpenGL methods directly and bypasses vanilla Minecraft's RenderSystem. RenderSystem caches OpenGL state to increase performance, but if any OpenGL state is changed behind its back and not restored to the exact same value, the cache will be out of sync and cause problems (in Sodium's case it causes rebinding of the lightmap to be skipped, since the cache believes it's already bound).

[RogueLogix]

bypassing the entirety of Mojang's OpenGL code is intentional, that said i wouldn't be surprised if there is a part of the state that is changed by Quartz in a way that normally is a non-issue, but does cause an issue in this case. if lodstone runs before quartz and changes state via RenderSystem to match what mojang will want later and quartz changes that, that is likely the cause.

it would be cleaner to save the old state and restore it, but I don't know how that affects performance

glGet* calls to save the state are generally quite expensive, as they may require a client to server thread sync, or worst case a sync to GPU, with a subsequent stall following that.

[Cicopath]

Is there any temporary solution to this issue?

I don't know by which mod end this issue is being caused, but I'm currently on version 1.18.2, and my world looks like... well, let the pictures explain themselves. I'm in F1 mode, but when I'm not in it, it looks as if some of the blocks are "z-fighting".

Minecraft version: 1.18.2
Forge: 40.2.10

Rubidium: 0.5.6
Rhino: 1802.2.21 build 255
Oculus: 1.6.4

Phosphophyllite: 0.6.0 beta 1.6
Quartz: 0.0.0 beta 1.4

Lodestone: 1.4.2

[embeddedt]

You can try using Embeddium instead of Rubidium.

[RogueLogix]

thread on discord where the issue is replicated on 1.19 as well.
https://discord.com/channels/767811985844469810/1170452736916070521