From 844d77010f9c010e8ea31ab1999fd4eb579ec507 Mon Sep 17 00:00:00 2001 From: davidfraenkel Date: Fri, 9 May 2025 10:55:02 +0200 Subject: [PATCH 1/4] Removed stupid test line --- .../IntegrationTests/Controllers/VenueIntegrationTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs b/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs index 79f2244..c1778fe 100644 --- a/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs +++ b/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs @@ -45,7 +45,7 @@ public async Task GetVenue__ReturnsVenue() // Arrange const int id = 4; var response = await _client.GetAsync($"/api/Venue/{id}"); - response.EnsureSuccessStatusCode(); + var returned = await response.Content.ReadFromJsonAsync(); // Assert From 7621ea614e44ff94a61ca4f59d7f41cf1bd6217e Mon Sep 17 00:00:00 2001 From: davidfraenkel Date: Fri, 9 May 2025 10:59:30 +0200 Subject: [PATCH 2/4] Fixed test id --- .../UnitTests/Controllers/RaspDataControllerTests.cs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/CrowdedBackend/CrowdedBackend.Tests/UnitTests/Controllers/RaspDataControllerTests.cs b/CrowdedBackend/CrowdedBackend.Tests/UnitTests/Controllers/RaspDataControllerTests.cs index 98289be..f012fa1 100644 --- a/CrowdedBackend/CrowdedBackend.Tests/UnitTests/Controllers/RaspDataControllerTests.cs +++ b/CrowdedBackend/CrowdedBackend.Tests/UnitTests/Controllers/RaspDataControllerTests.cs @@ -32,7 +32,6 @@ public async Task CreateRaspData() // Arrange var raspData = new RaspData { - Id = 1, MacAddress = "79:1C:89:6B:EC:C7", RaspId = 1, Rssi = -90, @@ -56,12 +55,12 @@ public async Task CreateRaspData() public async Task GetRaspData_ByName() { - _context.RaspData.Add(new RaspData { Id = 2, MacAddress = "79:1C:89:6B:EC:C7", RaspId = 1, Rssi = -90, UnixTimestamp = 1746033900000 }); + _context.RaspData.Add(new RaspData { Id = 998, MacAddress = "79:1C:89:6B:EC:C7", RaspId = 1, Rssi = -90, UnixTimestamp = 1746033900000 }); await _context.SaveChangesAsync(); // Act - var result = await _controller.GetRaspData(2); + var result = await _controller.GetRaspData(998); // Assert var actionResult = Assert.IsType>(result); @@ -75,11 +74,11 @@ public async Task GetRaspData_ByName() [Fact] public async Task DeleteRaspData_ById() { - _context.RaspData.Add(new RaspData { Id = 3, MacAddress = "79:1C:89:6B:EC:C7", RaspId = 1, Rssi = -90, UnixTimestamp = 1746033900000 }); + _context.RaspData.Add(new RaspData { Id = 999, MacAddress = "79:1C:89:6B:EC:C7", RaspId = 1, Rssi = -90, UnixTimestamp = 1746033900000 }); await _context.SaveChangesAsync(); // Act - var result = await _controller.DeleteRaspData(3); // Pass the ID of the venue to delete + var result = await _controller.DeleteRaspData(999); // Pass the ID of the venue to delete // Assert Assert.IsType(result); From 03bb949295e0f955a1bbb592eed443462abf34bb Mon Sep 17 00:00:00 2001 From: davidfraenkel Date: Fri, 9 May 2025 11:01:46 +0200 Subject: [PATCH 3/4] Removed stupid test line --- .../Controllers/VenueIntegrationTests.cs | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs b/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs index c1778fe..a5e8262 100644 --- a/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs +++ b/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs @@ -29,9 +29,6 @@ public async Task PostVenue_SavesVenue_ReturnsCreated() // Act: Send the POST request to the /api/Venue endpoint var response = await _client.PostAsJsonAsync("/api/Venue", venue); - // Assert: Ensure the response status code is 201 (Created) - response.EnsureSuccessStatusCode(); - // Deserialize the returned content to check the saved venue var returned = await response.Content.ReadFromJsonAsync(); @@ -59,7 +56,7 @@ public async Task GetVenue_UpdateVenue_ReturnsUpdatedVenue() // Arrange const int id = 4; var getResponse = await _client.GetAsync($"/api/Venue/{id}"); - getResponse.EnsureSuccessStatusCode(); + var originalVenue = await getResponse.Content.ReadFromJsonAsync(); Assert.NotNull(originalVenue); @@ -68,11 +65,11 @@ public async Task GetVenue_UpdateVenue_ReturnsUpdatedVenue() originalVenue.VenueName = "Updated Venue Name"; var putResponse = await _client.PutAsJsonAsync($"/api/Venue/{id}", originalVenue); - putResponse.EnsureSuccessStatusCode(); + // Assert - Get again and verify the updated name var confirmResponse = await _client.GetAsync($"/api/Venue/{id}"); - confirmResponse.EnsureSuccessStatusCode(); + var updatedVenue = await confirmResponse.Content.ReadFromJsonAsync(); Assert.Equal("Updated Venue Name", updatedVenue.VenueName); @@ -84,7 +81,7 @@ public async Task DeleteVenue_ReturnsDeletedVenue_And_CannotBeFoundAfter() // Arrange var venue = new Venue { VenueID = 99, VenueName = "Venue to Delete" }; var postResponse = await _client.PostAsJsonAsync("/api/Venue", venue); - postResponse.EnsureSuccessStatusCode(); + // Act var deleteResponse = await _client.DeleteAsync($"/api/Venue/{venue.VenueID}"); From 69bb4843031970dad8455b74f44ee4ca3c8ac9bd Mon Sep 17 00:00:00 2001 From: davidfraenkel Date: Fri, 9 May 2025 11:03:51 +0200 Subject: [PATCH 4/4] Fixed whitespace --- .../IntegrationTests/Controllers/VenueIntegrationTests.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs b/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs index a5e8262..e6379a6 100644 --- a/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs +++ b/CrowdedBackend/CrowdedBackend.Tests/IntegrationTests/Controllers/VenueIntegrationTests.cs @@ -56,7 +56,7 @@ public async Task GetVenue_UpdateVenue_ReturnsUpdatedVenue() // Arrange const int id = 4; var getResponse = await _client.GetAsync($"/api/Venue/{id}"); - + var originalVenue = await getResponse.Content.ReadFromJsonAsync(); Assert.NotNull(originalVenue); @@ -65,11 +65,11 @@ public async Task GetVenue_UpdateVenue_ReturnsUpdatedVenue() originalVenue.VenueName = "Updated Venue Name"; var putResponse = await _client.PutAsJsonAsync($"/api/Venue/{id}", originalVenue); - + // Assert - Get again and verify the updated name var confirmResponse = await _client.GetAsync($"/api/Venue/{id}"); - + var updatedVenue = await confirmResponse.Content.ReadFromJsonAsync(); Assert.Equal("Updated Venue Name", updatedVenue.VenueName); @@ -81,7 +81,7 @@ public async Task DeleteVenue_ReturnsDeletedVenue_And_CannotBeFoundAfter() // Arrange var venue = new Venue { VenueID = 99, VenueName = "Venue to Delete" }; var postResponse = await _client.PostAsJsonAsync("/api/Venue", venue); - + // Act var deleteResponse = await _client.DeleteAsync($"/api/Venue/{venue.VenueID}");