Frontier Pass Breaks CQUI...

[the-m4a]

EDIT: We have a functional version once again, and are moving work to the civfanatics github.
https://github.com/civfanatics/CQUI_Community-Edition

Posting here largely because this is where folks have historically looked...
Seems the new update broke CQUI. I will be investigating and checking changes into my branch, I'll send over a PR once I get done. (edit: this will be a slow process... ugh.)

Short form: Appears lots of things are broken, no city banners, leader scores, etc...

Any chance we can merge what is currently in expansion2 into master, @Azurency ? I never was able to figure out how to publish this thing on the Workshop, so I'm still at the mercy of someone that knows how to do so..

[danieldonaldson]

@the-m4a Hey bud, I think I managed to find a way to get it onto steam workshop, if you want to give it a try?

[cyrilh]

Notice that the spy screen has been broken even before Mai 21st Civ6 update.
Other things broken:

• trade completely broken and unusable (only possibility is to accept or decline an offer blindfolded) => This is a SEVERE problem
• diplomatic ribbon broken (if this is what it's called, top right of the screen, only show half of my civ)
  Another minor bug is using the latest More Lenses fixing player2 builder in Hotseat mode... see the specific ticket for that

I am unsubscribing from CQUI today and installing CQUI Light and More Lenses.

[skelzer]

Any chance you can share your branch as a git patch or something, @the-m4a ? Seeing as how it might be difficult to get a pull request through right now...

[the-m4a]

My master branch in my repo is the equivalent to the expansion2 branch here (Azurency's repo).
https://github.com/the-m4a/CQUI_Community-Edition

So while this mod is currently broken, if the code is fixed we can publish the mod to the workshop using that as the source?

I still lack the time I would like to otherwise have to work on this, but I'm trying... there were a number of changes made to the base files and the more I dig into this the more I come away thinking there is potentially a better way to do some of these things, but it may be a lot of work.

For example - the Diplomacy Ribbon is busted. The script file (DiplomacyRibbon.lua) in the mod was effectively copied from the base game files and modified. So any change to the base game file (as happened with this patch) is bound to have significant effect on the mod. If it's possible to inherit and override instead, that would make the mod a lot more stable through updates by Firaxis...

[the-m4a]

Notice that the spy screen has been broken even before Mai 21st Civ6 update.
Other things broken:

• trade completely broken and unusable (only possibility is to accept or decline an offer blindfolded) => This is a SEVERE problem
• diplomatic ribbon broken (if this is what it's called, top right of the screen, only show half of my civ)
  Another minor bug is using the latest More Lenses fixing player2 builder in Hotseat mode... see the specific ticket for that

I am unsubscribing from CQUI today and installing CQUI Light and More Lenses.

There's a CQUI Light? Yeah, lots of things broken...

[gbossu]

In the meantime, for anyone wanting to play, you can always change the AffectsSavedGames attribute to 0 in the CQUI.modinfo, then load your savegame, save it and load it again. This is probably not 100% safe (I guess there's a reason it was marked as affecting saved games), but in my case it seems to work totally fine. You will just realize how bad the base UI is, and want to thank people like @the-m4a even more for maintaining CQUI :D

[wayneb64]

I went offline in Steam the moment I heard about the new DLCs coming as I knew they would break CQUI for me. Hearing about the six releases every other month was bad news as I knew CQUI would be broken at least six times if not more (they might need to drop hot fixes). I would like to support Firaxis as I like their content but they seem to have given zero effort to support the modders and they also don't even support an option to NOT take their new content (until the mods are ready).

BTW, I have never noticed any issues with the Spy panel, seems to work fine for me.

EDIT: What is broken is National Parks, has anyone been able to build one with CQUI? The lens at least is broken, maybe more. Be real nice if that could be fixed.

[hartmark]

This code is out of my skill so I hope someone will pickup this and continue maintain it to keep in sync with the new patches

[alimulhuda]

I've started to look into fixing bits and pieces. So far I think I've gotten the diplomacy banner and city banner working. I'm new to Lua and Civ 6 modding so it's possible I've missed things. The version I'm working on is here https://github.com/alimulhuda/CQUI_Community-Edition/tree/expansion2.

For the diplomacy ribbon I've tried to do the inheritance/override approach, but for that I had to get rid of the CQUI detailed diplomacy ribbon and instead rely on the unmodded game detailed ribbon (that one happens to have more details so nothing lost hopefully).

[the-m4a]

awesome, @alimulhuda - I'll take a peek at what you have going on. I've been trying to wrap my head around a few things with this mod, and just the Civ6 modding in general. I've spent a loony amount of time today just trying to work out how to reduce as much replacing of files as possible. It bothers me that Civ6Common.lua is one of the replaced files and while there weren't a lot of changes with this update, that file gets loaded so often it feels like a bad idea to do that.
I think I understand why it was done, though - some global database thing going on there. It doesn't feel like the right way to do it, but I at least have it down to just a couple of lines worth of changes and can look back into it later...

Also @wayneb64 I know I had done a national park, though I think you're correct that the lens was not functional.

Speaking of lenses, I saw there was an update to the More Lenses mod (standalone) version made today, which is probably worthy of incorporation...

[doomsday-machine]

Registered just to write this comment haha.
@alimulhuda I'm not sure if I understand your approach, but in case this helps, I'd start by fixing the city UI:

• unit flags (worker charges, promotions)
• city banners
• mouse shortcuts (click banner to enter city), purchase buttons etc.
  And disable all the rest, but make the above changes so it's at least playable.

Mega thank you!

[alimulhuda]

@wayneb64 If you still have the pre-patch versions of the UI files it would help me a lot if you could get them to me somehow. Having them would help me reduce the guess work in figuring out the changes I would need to make. If I can do a diff between the mod files and the original files then I can know for sure which changes are the mod. Right now it's a mix of guesswork and relying on the variable naming scheme that the mod makers use.

The folders I would like to look at are
C:\Program Files (x86)\Steam\steamapps\common\Sid Meier's Civilization VI\Base\Assets\UI (Without the fonts folder since that one is huge)
C:\Program Files (x86)\Steam\steamapps\common\Sid Meier's Civilization VI\DLC\Expansion1\UI
C:\Program Files (x86)\Steam\steamapps\common\Sid Meier's Civilization VI\DLC\Expansion2\UI

If having a more detailed wishlist from me would help, then let me know and I'll go through and figure out which exact files I might need. Thanks in advance.

[alimulhuda]

@doomsday-machine I'm currently only focusing on making it work for the Gathering Storm version. The city banner should be fixed in my repository. The worker charges and promotions doesn't seem broken. The click banner to enter city and purchasing units also doesn't seem to be broken.

You can try it out by following the instructions for manual install (https://github.com/Azurency/CQUI_Community-Edition#manually). You might need to unsubscribe from the one in the workshop first. I don't know which version the game will use if you have both the one from steam workshop and the manual installed one.

Disabling the things not working might not be easy for me to do, this is the first time I'm working on something like this. The next one I think I would look at would be the diplomacy trade screen, since that one is broken in a bad way.

[wayneb64]

@wayneb64 If you still have the pre-patch versions of the UI files it would help me a lot if you could get them to me somehow. Having them would help me reduce the guess work in figuring out the changes I would need to make. If I can do a diff between the mod files and the original files then I can know for sure which changes are the mod. Right now it's a mix of guesswork and relying on the variable naming scheme that the mod makers use.

The folders I would like to look at are
C:\Program Files (x86)\Steam\steamapps\common\Sid Meier's Civilization VI\Base\Assets\UI (Without the fonts folder since that one is huge)
C:\Program Files (x86)\Steam\steamapps\common\Sid Meier's Civilization VI\DLC\Expansion1\UI
C:\Program Files (x86)\Steam\steamapps\common\Sid Meier's Civilization VI\DLC\Expansion2\UI

If having a more detailed wishlist from me would help, then let me know and I'll go through and figure out which exact files I might need. Thanks in advance.

UI.zip
Expansion1_UI.zip
Expansion2_UI.zip

Let me know if these uploaded OK.

[alimulhuda]

@wayneb64 Just took a quick look and it seems like all the files I might want to look at are present. Thanks again.