Skip to content

Fix invalid platform restrictions in package-lock.json and make benchmark setup non-blocking #46

Description

@Just-Bamford

Description

Problem

package-lock.json contains incorrect os restrictions for three pure JavaScript dependencies:

  • pretty-format@29.7.0["aix"]
  • resolve.exports@2.0.3["linux"]
  • semver@6.3.1["linux"]

These restrictions cause npm install and npm ci to fail on unsupported platforms and also break the benchmark workflow when it checks out main and installs dependencies.

Additionally, .github/workflows/benchmarks.yml only provides a fallback for npm run bench, while a failed npm ci causes the benchmark job to fail before the fallback is reached.

Solution

Regenerate package-lock.json from the current package manifest to remove the incorrect platform metadata.

Update the benchmark workflow so failures while installing the main baseline are handled as non-blocking, consistent with the workflow's manual comparison purpose.

Acceptance Criteria

  • package-lock.json no longer contains incorrect os restrictions.
  • npm ci succeeds on Linux, macOS, and Windows.
  • The benchmark workflow handles a failed baseline install without failing the PR job.
  • Benchmark output clearly indicates when a baseline is unavailable.
  • No package versions are changed unless required by lockfile regeneration.

Note for Contributors

Regenerate the lockfile using the repository's supported Node.js and npm versions. Do not manually edit integrity hashes or dependency metadata.

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26bugSomething isn't workinggood first issueGood for newcomershelp wantedExtra attention is needed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions