Commit modal shows wrong variant name for new variants

[mmabrouk]

When creating a new variant from the commit modal, the modal title shows the old variant name instead of the new one.

Observed behavior: after selecting Create new variant and entering a new variant name such as new-var, the modal title still displays Commit to default.

Expected behavior: the left side should show the old variant name, and the blue text should show the new variant name with v1.

[linear-code]

AGE-3832

[dosubot]

The bug is in web/oss/src/components/Playground/Components/Modals/CommitVariantChangesModal/index.tsx — the modal title is hardcoded as "Commit changes" on line 96 and never updates dynamically [1].

The component already has access to both variantName (the current variant) and selectedCommitType.name (the new variant name entered by the user), but neither is used in the title prop [2].

A fix would make the title dynamic based on selectedCommitType.type:

title={`Commit to ${selectedCommitType.type === "variant" && selectedCommitType.name ? selectedCommitType.name : variantName}`}

This way, when the user selects "As a new variant" and types new-var, the title updates to "Commit to new-var" instead of staying static.

To reply, just mention @dosu.

---

Share context across your team and agents. Try Dosu.

[Sanket2329]

@mmabrouk Hi! I'd like to work on this issue if it's available. Could I be assigned to it?

[mmabrouk]

Yes done

[Sanket2329]

Hi @mmabrouk,

I implemented the fix by separating the original source variant name from the user-entered target variant name.
The transition panel now correctly displays:
default v1 → new-var v1
and the explanatory text references the source variant (default) rather than the typed target variant.
Could you confirm whether the modal title should continue to reference the source variant being committed, or whether you'd like it to display the target variant name as well?

[mmabrouk]

I implemented the fix by separating the original source variant name from the user-entered target variant name.
The transition panel now correctly displays:
default v1 → new-var v1
and the explanatory text references the source variant (default) rather than the typed target variant.
Could you confirm whether the modal title should continue to reference the source variant being committed, or whether you'd like it to display the target variant name as well?

@Sanket2329
The behavior sounds correct. Just to check, if I have variant myvariant v3 open, and I click on commit and write new variant mynewvariant

I will see:

myvariant v3 -> mynewvariant v1

Correct?

[Sanket2329]

@mmabrouk
Yes, that is exactly correct! It will display myvariant v3 ➔ mynewvariant v1 in the transition panel.
The PR has been merged and this is fully resolved. Thank you!

[Sanket2329]

Hi @mmabrouk!
Now that the fix in PR #4694 has been merged, this issue is fully resolved and can be closed.
Thank you!