From 20358f53de95a7eb5ea852b9d1342677c26c3ebd Mon Sep 17 00:00:00 2001 From: Efty Sifakis Date: Wed, 2 Sep 2026 17:46:19 -0500 Subject: [PATCH] nanovdb: install six missing public headers cuda/Buffer.h, cuda/PinnedResource.h, math/Proximity.h, tools/cuda/MeshToGrid.cuh, util/MaskPrefixSum.h and util/cuda/Rasterization.cuh are in the source tree but absent from the install lists, so the installed tree contained headers referencing files it did not ship: 42 installed headers reach cuda/Buffer.h and two reach util/MaskPrefixSum.h. In-tree builds compile against the source directory, where every header exists, so the omissions stay invisible until the headers are installed. Compiling a translation unit that includes each installed header against an installed prefix goes from 40/88 to 83/94, with the 44 missing-file errors eliminated. Signed-off-by: Efty Sifakis --- nanovdb/nanovdb/CMakeLists.txt | 6 ++++++ pendingchanges/missinginstallheaders.txt | 7 +++++++ 2 files changed, 13 insertions(+) create mode 100644 pendingchanges/missinginstallheaders.txt diff --git a/nanovdb/nanovdb/CMakeLists.txt b/nanovdb/nanovdb/CMakeLists.txt index 8f4fa07c56..0a1d609c96 100644 --- a/nanovdb/nanovdb/CMakeLists.txt +++ b/nanovdb/nanovdb/CMakeLists.txt @@ -199,12 +199,14 @@ set(NANOVDB_INCLUDE_FILES # NanoVDB cuda header files set(NANOVDB_INCLUDE_CUDA_FILES + cuda/Buffer.h cuda/DeviceBuffer.h cuda/DeviceMesh.h cuda/DeviceResource.h cuda/DeviceStreamMap.h cuda/GridHandle.cuh cuda/NodeManager.cuh + cuda/PinnedResource.h cuda/TempPool.h cuda/UnifiedBuffer.h ) @@ -220,6 +222,7 @@ set(NANOVDB_INCLUDE_MATH_FILES math/DitherLUT.h math/HDDA.h math/Math.h + math/Proximity.h math/Ray.h math/SampleFromVoxels.h math/Stencils.h @@ -254,6 +257,7 @@ set(NANOVDB_INCLUDE_TOOLS_CUDA_FILES tools/cuda/DilateGrid.cuh tools/cuda/CoarsenGrid.cuh tools/cuda/VoxelBlockManager.cuh + tools/cuda/MeshToGrid.cuh ) # NanoVDB util header files @@ -283,6 +287,7 @@ set(NANOVDB_INCLUDE_UTIL_FILES util/Timer.h util/Util.h util/MorphologyHelpers.h + util/MaskPrefixSum.h ) # NanoVDB util/cuda header files @@ -305,6 +310,7 @@ set(NANOVDB_INCLUDE_UTIL_CUDA_FILES util/cuda/MorphologyHelpers.cuh util/cuda/DeviceGridTraits.cuh util/cuda/Injection.cuh + util/cuda/Rasterization.cuh ) add_library(nanovdb INTERFACE) diff --git a/pendingchanges/missinginstallheaders.txt b/pendingchanges/missinginstallheaders.txt new file mode 100644 index 0000000000..d9ea1c4950 --- /dev/null +++ b/pendingchanges/missinginstallheaders.txt @@ -0,0 +1,7 @@ +NanoVDB: + Bug Fixes: + - Fixed six public headers missing from the install lists in nanovdb/CMakeLists.txt: + cuda/Buffer.h, cuda/PinnedResource.h, math/Proximity.h, tools/cuda/MeshToGrid.cuh, + util/MaskPrefixSum.h and util/cuda/Rasterization.cuh. Installed headers included two of + them, so including a header such as nanovdb/cuda/GridHandle.cuh from an installed + NanoVDB failed to compile.