Build fails with gcc15.1/boost 1.89

[rossburton]

Trying to upgrade to gator daemon 9.6 but it's failing to build (GCC 15.1, Boost 1.98):

| FAILED: [code=1] CMakeFiles/gatord.dir/Child.cpp.o
| ccache /work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/recipe-sysroot-native/usr/bin/aarch64-poky-linux/aarch64-poky-linux-g++ --sysroot=/work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/recipe-sysroot -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_DEPRECATED -DBOOST_FILESYSTEM_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DETCDIR=\"/etc\" -I/work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/sources/gator-daemon-9.6.0/daemon -I/work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/build -I/work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/sources/gator-daemon-9.6.0/daemon/hwcpipe2/device/include -I/work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/sources/gator-daemon-9.6.0/daemon/../ext -isystem /work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/sources/gator-daemon-9.6.0/daemon/extheaders -isystem /work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/sources/gator-daemon-9.6.0/daemon/libsensors -mcpu=cortex-a57+crc -mbranch-protection=standard -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security  --sysroot=/work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/recipe-sysroot  -O2 -g  -ffile-prefix-map=/work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/sources/gator-daemon-9.6.0/daemon=/usr/src/debug/gator-daemon/9.6.0  -ffile-prefix-map=/work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/build=/usr/src/debug/gator-daemon/9.6.0  -ffile-prefix-map=/work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/recipe-sysroot=  -ffile-prefix-map=/work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/recipe-sysroot-native=  -pipe -fvisibility-inlines-hidden -fvisibility=hidden -fexceptions -ffile-prefix-map=/work/ross/build/tmp=. -Wall -Wextra -Wno-shadow -Wno-psabi -g -g -ggdb3 -gdwarf-3 -D_DEBUG -std=gnu++17 -MD -MT CMakeFiles/gatord.dir/Child.cpp.o -MF CMakeFiles/gatord.dir/Child.cpp.o.d -o CMakeFiles/gatord.dir/Child.cpp.o -c /work/ross/build/tmp/work/cortexa57-poky-linux/gator-daemon/9.6.0/sources/gator-daemon-9.6.0/daemon/Child.cpp
| In file included from ../sources/gator-daemon-9.6.0/daemon/logging/agent_log.h:5,
|                  from ../sources/gator-daemon-9.6.0/daemon/agents/spawn_agent.h:11,
|                  from ../sources/gator-daemon-9.6.0/daemon/agents/agent_workers_process_holder.h:6,
|                  from ../sources/gator-daemon-9.6.0/daemon/Child.h:8,
|                  from ../sources/gator-daemon-9.6.0/daemon/Child.cpp:3:
| ../sources/gator-daemon-9.6.0/daemon/async/async_line_reader.hpp: In lambda function:
| ../sources/gator-daemon-9.6.0/daemon/async/async_line_reader.hpp:51:74: error: 'const_buffers_1' is not a member of 'boost::asio'; did you mean 'const_buffer'? [-Wtemplate-body]
|    51 |                                                             boost::asio::const_buffers_1>);
|       |                                                                          ^~~~~~~~~~~~~~~
|       |                                                                          const_buffer
| ../sources/gator-daemon-9.6.0/daemon/async/async_line_reader.hpp:51:89: error: template argument 2 is invalid [-Wtemplate-body]
|    51 |                                                             boost::asio::const_buffers_1>);
|       |                                                                                         ^
| ../sources/gator-daemon-9.6.0/daemon/Child.cpp: In member function 'void Child::run()':
| ../sources/gator-daemon-9.6.0/daemon/Child.cpp:200:5: error: 'mxmlSetWrapMargin' was not declared in this scope; did you mean 'mxmlOptionsSetWrapMargin'?
|   200 |     mxmlSetWrapMargin(0);
|       |     ^~~~~~~~~~~~~~~~~
|       |     mxmlOptionsSetWrapMargin

[staehle]

Hey @rossburton, even if its not working completely, would you happen to have a commit somewhere with your version of a gator_9.6.0.bb file and any patches you have? I'm working on my own version of that, and I'm running into some different issues (not related to the above) with protoc seemingly not compiling the proto file.

That info might be useful for this ticket anyways

Thanks!

[rossburton]

Sure, https://gitlab.com/rossburton/meta-arm/-/tree/gator/meta-arm/recipes-devtools/gator?ref_type=heads.

[staehle]

Thanks @rossburton ! My recipe file was actually almost exactly the same (I just did a dumb and had protobuf but not protobuf-native in my DEPENDS, thanks for the hint haha)

I'm using gcc 14.2, boost 1.80.0, and added libmxml 3.3.1, so I didn't end up running into your specific compile issue, but found and fixed a few others. I raised a separate issue for my final link issue: #62

Heres the patch I used for my setup: 0001-Compile-fixes-for-boost-1.80.0.patch

And doing some real quick searches I came up with a second patch that might (no guarantees haha) work for your boost 1.86+ and libmxml 4 setup: 0002-MXML4-Boost-1.86-compile-fixes.patch I'm not too familiar with either of these, however.

[bengaineyarm]

@rossburton (and also @staehle) - #63

This fixes issues with boost 1.89 and protobuf 5.29.5 (tested using our vcpkg based build scripts).

NB: MXML 4 is a major version change and will not be supported at this point since it introduces a number of breaking api changes so is not just a simple fix.

This is compiled with the build-linux.sh script provided and passes with GCC 15.2 (along with clang-18).