[codex] Remove Conductor root from README paths#43
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates README CLI examples to use relative local cache and session directories instead of paths derived from a ChangesCLI Examples Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the README quickstart examples to avoid relying on the Conductor-specific $CONDUCTOR_ROOT_PATH environment variable, making the documented commands work in any standard checkout/workspace.
Changes:
- Replaced
$CONDUCTOR_ROOT_PATH/.gmaps-scraper/...with relative.gmaps-scraper/...paths for session storage. - Replaced
$CONDUCTOR_ROOT_PATH/.gmaps-scraper/...with relative.gmaps-scraper/...paths for LLM cache storage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
$CONDUCTOR_ROOT_PATHwith relative.gmaps-scraper/...paths.Impact
This keeps the quickstart examples independent of Conductor-specific workspace environment variables.
Validation
rg -n "CONDUCTOR_ROOT_PATH" README.mdreturned no matches.ruff,mypy.Summary by CodeRabbit
.gmaps-scraper/sessionand.gmaps-scraper/llm-cache) instead of environment variable-based paths for session and cache storage.