Skip to content
This repository was archived by the owner on Jun 15, 2022. It is now read-only.
This repository was archived by the owner on Jun 15, 2022. It is now read-only.

use rbenv instead of chruby for consistency with repo code #188

Description

@bleachbyte

Despite this note...

fancy_echo 'We recommend chruby and ruby-install over RVM or rbenv'

...there doesn't appear to be a specific reason that this script uses chruby/ruby-install over rbenv. In addition:

  • the rbenv binary appears in numerous places throughout our code, while the chruby one does not
  • chruby allows for fuzzy-version installs, which can potentially be problematic if the third version octet isn't specified
  • switch_to_latest_ruby() is dependent on /usr/local/share/chruby/chruby.sh existing, despite the fact that an installer, and support, for rbenv (currently just with fish) exists in the file

Unless there's a specific infrastructure reason for staying with chruby over rbenv I believe it would make more sense to just use the rbenv installation process, possibly coupled with some extra commands to easily set up aliases for the various .ruby-version files.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions